Finished CloudFront support #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
FYI, I plan to review this this weekend. |
Allows adding a certificate to new CloudFront distributions that didn't have any certificate yet.
|
Hi! What's the status of this? We'd like to use it! |
Author
|
Seems that this PR is lost. So many commits on master that it would have to be rewritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are my fixes for your PR #44 that fixes #41. Using this I was able to create, upload and configure certificate for my CloudFront distribution that didn't even use any SSL cert before. After that I've verified that on a second run the existing cert is checked for its settings and expiration time.
I didn't realize I was working in parallel with @kageurufu who submitted #56. I like his
--cert-onlyoption, but we took different approaches. I've based my PR on your topic branch and put my changes in multiple separate commits hoping it will make them easier to review.