[Filter][2165]filter_for_data_set_name #2390
Conversation
AndreMarcel99
changed the title
richp405
left a comment
richp405
left a comment
There was a problem hiding this comment.
This can't be merged until the pep8 and bandit issues are resolved.
It looks like a decent change, but non-standard... should be an easy couple of fixes.
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
Requested one change and asked a question
| from ansible.errors import AnsibleFilterError | ||
|
|
||
|
|
||
| def generate_data_set_name(value, generations=1): |
There was a problem hiding this comment.
At first sight generations might seem to be referring to a different thing, it will be better to use something like count or num_names
|
|
||
| EXAMPLES: | | ||
| # Get only one data set name. | ||
| clean_output: "{{ hlq | ibm.ibm_zos_core.generate_data_set_name}}" |
There was a problem hiding this comment.
What is the result if I do this ?
{{ ibm.ibm_zos_core.generate_data_set_name }}
Asking because I would expect to have either an error or a randomly generated hlq, when using mvstmp it uses the result of whoami command
There was a problem hiding this comment.
I think in this case we cannot generate a valid HLQ even having the ansible user, so we could fail in case no HLQ is provided
There was a problem hiding this comment.
Thanks for adding this!!
There was a problem hiding this comment.
Please update the copyright year
There was a problem hiding this comment.
Looks good, would only add one testing when is empty (if possible even)
rexemin
left a comment
rexemin
left a comment
There was a problem hiding this comment.
Looks great, just spotted a couple of typos and I would also like to see a response to Fernando's comments about calling the filter without parameters
Co-authored-by: Alex Moreno <iamorenosoto@gmail.com>
Co-authored-by: Alex Moreno <iamorenosoto@gmail.com>
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
requested one last change
| - Middle level qualifier to be used in the data set names. | ||
| type: str | ||
| required: false | ||
| last_level_qualifier: |
There was a problem hiding this comment.
I recommend to change last_level_qualifier to low_level_qualifier since that is how it is referred in the IBM docs.
|
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
Looks good to me now thanks
SUMMARY
Filter to get data set names Fixes #2165
ISSUE TYPE
COMPONENT NAME
Generate data set name from the components use on the tests data set helpers
