feat: add Named Selections query to geometric entities #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2356 +/- ##
==========================================
- Coverage 95.20% 95.19% -0.02%
==========================================
Files 168 168
Lines 11103 11174 +71
==========================================
+ Hits 10571 10637 +66
- Misses 532 537 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
reviewed
Nov 12, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Some comments! Looks pretty good though :)
Comment on lines
+1906
to
+1908
| @ensure_design_is_active | ||
| def get_named_selections(self) -> list["NamedSelection"]: # noqa: D102 | ||
| return self._template.get_named_selections(self) |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
It should probably be done at the body level. I will change this
Comment on lines
+1296
to
+1299
| named_selections = get_design_from_body(body).named_selections | ||
|
|
||
| included_ns = [] | ||
| for ns in named_selections: |
Member
There was a problem hiding this comment.
Suggested change
| named_selections = get_design_from_body(body).named_selections | |
| included_ns = [] | |
| for ns in named_selections: | |
| included_ns = [] | |
| for ns in get_design_from_body(self).named_selections: |
Comment on lines
+91
to
+93
| if self.parent_component is None: | ||
| raise ValueError("Design point does not have a parent component.") | ||
|
|
Member
There was a problem hiding this comment.
Is this even possible? Shouldn't it only be created from a modeling perspective? What's the case when a DesignPoint gets created without parent component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Closes #2326
Checklist
feat: extrude circle to cylinder)