Skip to content

Conversation

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Nov 6, 2025

Description [WIP]

Improvements on the update from tracker method due to recent enhancements on the backend tracker response. Now after each operation we are getting the bodies/components/parts that are created/modified/deleted. It is still behind the feature flag so "safe" to merge. but we also need to generate more test cases that prove its robustness and efficiency.

This also needs for some proto updates that will only happen in V1. so we may park it here for a while.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 6, 2025
@umutsoysalansys umutsoysalansys changed the title Feat/tracking updates feat/tracking updates Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 8.36237% with 263 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.53%. Comparing base (6aa7ad7) to head (b902219).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/design.py 7.52% 258 Missing ⚠️
src/ansys/geometry/core/tools/prepare_tools.py 25.00% 3 Missing ⚠️
...ys/geometry/core/_grpc/_services/v0/conversions.py 50.00% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (81.53%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (6aa7ad7) and HEAD (b902219). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (6aa7ad7) HEAD (b902219)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2359       +/-   ##
===========================================
- Coverage   95.36%   81.53%   -13.83%     
===========================================
  Files         168      156       -12     
  Lines       11101    11178       +77     
===========================================
- Hits        10586     9114     -1472     
- Misses        515     2064     +1549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants