fix(migrated PR 4207): issue 4206 #4279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Closed
germa89
changed the title
germa89
changed the title
germa89
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4279 +/- ##
==========================================
- Coverage 91.39% 91.34% -0.05%
==========================================
Files 193 193
Lines 15726 15742 +16
==========================================
+ Hits 14372 14380 +8
- Misses 1354 1362 +8 🚀 New features to boost your workflow:
|
…s.py Add explicit type hints for math_header, array_header, is_parameter_listing, is_math_listing, is_array_listing, and interp_star_status to improve clarity and support static analysis.
Add golden "c_fullfile status" sample and multiple tests to verify interp_star_status correctly parses C_FullFile entries. Cover mixed SMAT/C_FullFile outputs, single C_FullFile outputs, and various C_FullFile-like names; ensure only the "type" field is present for C_FullFile parameters and other fields (value, MemoryMB, workspace, shape) are not included. Also include the c_fullfile case in the parameterized status test.
germa89
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a mirror pull request created from Fix issue 4206 to allow the code to access PyMAPDL CICD secrets.
Check the original PR made by @ChaiF1 for more details.
Closes #4207
Original pull request
Fix issue 4206
This is a small PR to give the code I used to fix issue #4206 which I encountered in my work. The issue is broader than my fix so more code is needed to make the problems described in the issue go away. This can be used as a start to start fixing the entire underlying problem.