Add a statically dispatched version of make_comparator
#8814
+1,429
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
force-pushed
the
typed-comparator
branch
from
dfc8cd3 to
6edfedf
Compare
Contributor
|
Would be nice to see the sorting benchmarks on this change! My feeling is it might significantly reduce the overhead of the lexical sorting kernels (compared to row format). |
Contributor
Author
|
Or it might make it worse… it’s a trade off of indirection vs branch prediction. As we found out in apache/datafusion#18449 the same change can be 70% faster on ARM MacBooks and 70% slower on x86. So needless to say this should not be merged without benchmarks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on apache/datafusion#18449 it came up that the dynamic dispatch here can hurt performance for simple types. This version seems to perform better in benchmarks there (admittedly run alongside other changes).