feat(laravel): Enable to skip autoconfiguration with new SkipAutoconfigure attribute
#7467
+29
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered an issue where a circular dependency could occur when decorating a system processor such as
WriteProcessor.For example, create a decorator for
WriteProcessorcalledAppWriteProcessoras follows:In this case, because
AppWriteProcessorimplementsProcessorInterface, it is tagged withProcessorInterfaceand is therefore included as a dependency ofCallableProcessor.Furthermore, because
CallableProcessoris included in the dependencies ofWriteProcessor, a circular dependency occurs:CallableProcessor->AppWriteProcessor->WriteProcessor->CallableProcessor.The only two ways to prevent this is to change the constructor argument type of
AppWriteProcessortomixedinstead ofWriteProcessor, or to remove the tagging ofAppWriteProcessorwithProcessorInterface.This PR introduces a new
SkipAutoconfigureattribute, which allows you to exclude some application code fromautoconfigure.I've created a minimal environment to reproduce this issue in the following GitHub repository, and the commit logs explain the process to resolve it.
https://github.com/ttskch/api-platform-laravel-system-provider-decoration-example/commits/main/