perf: Use Apify-provided environment variables to obtain PPE pricing information #644
+109
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbuchar
reviewed
Oct 24, 2025
Comment on lines
+341
to
+355
| charged_counts = json.loads(self._configuration.charged_event_counts) | ||
|
|
||
| # Validate pricing info with proper discriminator support | ||
| pricing_info_adapter: TypeAdapter[ | ||
| FreeActorPricingInfo | ||
| | FlatPricePerMonthActorPricingInfo | ||
| | PricePerDatasetItemActorPricingInfo | ||
| | PayPerEventActorPricingInfo | ||
| ] = TypeAdapter( | ||
| FreeActorPricingInfo | ||
| | FlatPricePerMonthActorPricingInfo | ||
| | PricePerDatasetItemActorPricingInfo | ||
| | PayPerEventActorPricingInfo | ||
| ) | ||
| pricing_info = pricing_info_adapter.validate_json(self._configuration.actor_pricing_info) |
There was a problem hiding this comment.
I'd move this to the Configuration class itself so that self._configuration.actor_pricing_info is already parsed and validated
class Configuration
...
actor_pricing_info: Annotated[FreeActorPricingInfo | ..., Field(...), BeforeValidator(json.loads)]| def get_max_total_charge_usd(self) -> Decimal: | ||
| return self._max_total_charge_usd | ||
|
|
||
| async def _fetch_pricing_info(self) -> dict[str, Any]: |
There was a problem hiding this comment.
Please return a better type here
|
|
||
| # Set up charging log dataset for local development | ||
| if not self._is_at_home and self._pricing_model == 'PAY_PER_EVENT': | ||
| # We are not running on the Apify platform, but PPE is enabled for testing - open a dataset that |
There was a problem hiding this comment.
What was wrong with that comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #614