Skip to content

Allow proxying requests for private API #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Allow proxying requests for private API #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fc552d2
moving the appupgrade api url to a variable.
adteulade May 31, 2023
4bda0ff
Merge pull request #1 from Pod-Point/EDA-772-adding-variable-for-api-url
adteulade May 31, 2023
e0e211a
updating the package.json data so a new package can be published to npm.
adteulade May 31, 2023
80edd7b
Merge pull request #2 from Pod-Point/EDA-772-updating-package-json
adteulade May 31, 2023
72f5c10
fix: issue in version-check.
adteulade May 31, 2023
b0a8657
Merge pull request #3 from Pod-Point/EDA-772-updating-the-version-check
adteulade May 31, 2023
aec8fcf
fix: adjusting new version.
adteulade May 31, 2023
c4273d2
fix: issue with import.
adteulade Jun 2, 2023
b607d71
version 1.0.2
adteulade Jun 2, 2023
2b0547d
fix: bad import, version 1.0.3
adteulade Jun 2, 2023
60110ab
fix: removing uri part, version 1.0.4
adteulade Jun 2, 2023
dcd3c74
Merge branch 'main' into merge-to-main-repo
adteulade Mar 20, 2024
799fc60
chore: reverting changes related to fork, adding optional baseUrl
adteulade Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ const PreferredAndroidMarket = {
OTHER: 'Other',
}

function appUpgradeVersionCheck(appInfo, xApiKey, alertInfo) {
versionCheck(appInfo, xApiKey, alertInfo);
function appUpgradeVersionCheck(appInfo, xApiKey, alertInfo, baseUrl) {
versionCheck(appInfo, xApiKey, alertInfo, baseUrl);
}

export { appUpgradeVersionCheck, PreferredAndroidMarket };
6 changes: 3 additions & 3 deletions src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import axios from "axios";
import axiosRetry from "axios-retry";

async function checkVersionWithAppUpgrade(appInfo, xApiKey) {
async function checkVersionWithAppUpgrade(appInfo, xApiKey, baseUrl = '') {
try {
const appUpgradeBaseUrl = "https://appupgrade.dev";
const appUpgradeBaseUrl = baseUrl ? baseUrl : "https://appupgrade.dev/api/v1/versions/check";
const { appName, appVersion, platform, environment, appLanguage } = appInfo;

const { customAttributes } = appInfo;
Expand All @@ -27,7 +27,7 @@ async function checkVersionWithAppUpgrade(appInfo, xApiKey) {
}

const response = await axios.get(
`${appUpgradeBaseUrl}/api/v1/versions/check`,
appUpgradeBaseUrl,
{
headers: {
"x-api-key": xApiKey,
Expand Down
4 changes: 2 additions & 2 deletions src/version-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { checkVersionWithAppUpgrade } from "./api";
import { Platform, Alert, Linking } from "react-native";
import { PreferredAndroidMarket } from "app-upgrade-react-native-sdk";

async function versionCheck(appInfo, xApiKey, alertInfo) {
async function versionCheck(appInfo, xApiKey, alertInfo, baseUrl) {
const isValid = validate(appInfo, xApiKey);

if (isValid) {
const version = await checkVersionWithAppUpgrade(appInfo, xApiKey);
const version = await checkVersionWithAppUpgrade(appInfo, xApiKey, baseUrl);
if (!version) {
console.error("App Upgrade Error: Version is null.");
} else if (version && version.found === true) {
Expand Down