-
Couldn't load subscription status.
- Fork 84
feat: AVR Compatibility #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 95.26% 95.11% -0.15%
==========================================
Files 32 31 -1
Lines 1478 1434 -44
==========================================
- Hits 1408 1364 -44
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ b304eb3
Click for full report table
Click for full report CSV |
|
Memory usage change @ d5966e6
Click for full report table
Click for full report CSV |
This modifies the implementation to be compatible with
avr-gcc, which can then be supported by the Notecard.The core change is to templatize the implementation on
CloudInt.This allows the library to accept all sizes and signed-ness of integers without requiring multiple implementations (e.g.
CloudInt,CloudUnsignedInt, etc...). Several cascading changes are then required to accommodate this main change.Other changes include pulling in ArduinoSTL for
std::listsupport, and migrating lambda expressions to static functions.