Add serial input text field to plotter #8929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cactorium , this looks useful. Are you going to fix the issue the automatic check found? |
|
Oh, I didn't see that, give me a couple minutes |
|
@ElectricRCAircraftGuy Just checking in, I think it's passing the check now |
|
Awesome. I'm just a third party observer though so unfortunately I can't do anything to help it land. I'm just watching this is all. |
cmaglie
added
the
Type: Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an input text field to the Serial Plotter so that input can be transmitted to the Arduino while receiving plottable data. Most of it was just copied from
AbstractTextMonitorandSerialMonitorintoSerialPlotter