Wrap signing certificate password in single quotes to prevent corruption #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High quality passwords may contain characters with special treatment by the shell (e.g., $). The release workflows contain a command that imports the macOS code signing certificate to the runner machine's keychain. The command references a GitHub Actions secret that contains the password of the certificate. Previously, that reference was wrapped in double quotes. This resulted in the password string being subject to shell expansions. If the password contained characters that incidentally resemble shell code, this resulted in the corruption of the password, nd thus a spurious failure of the release workflow: ``` security: SecKeychainItemImport: The user name or passphrase you entered is not correct. ```
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap signing certificate password in single quotes to prevent corruption
High quality passwords may contain characters with special treatment by the shell (e.g., $).
The release workflows contain a command that imports the macOS code signing certificate to the runner machine's keychain. The command references a GitHub Actions secret that contains the password of the certificate.
Previously, that reference was wrapped in double quotes. This resulted in the password string being subject to shell expansions. If the password contained characters that incidentally resemble shell code, this resulted in the corruption of the password, nd thus a spurious failure of the release workflow: