-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Introduce including user provided first-boot config at build time #8692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
action.yml (1)
15-19
: Consider splitting unrelated changes into separate PRs.This PR's objective is to "Introduce including user provided first-boot config at build time," but these changes add release artifact cleanup functionality, which appears unrelated to firstboot configuration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
action.yml
(2 hunks)lib/functions/rootfs/distro-agnostic.sh
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
lib/functions/rootfs/distro-agnostic.sh (1)
.github/generate_CODEOWNERS.sh (1)
display_alert
(6-6)
🔇 Additional comments (2)
action.yml (1)
215-215
: LGTM!The usage of
inputs.armbian_release_clean
forremoveArtifacts
is correct and properly defaults to"false"
.lib/functions/rootfs/distro-agnostic.sh (1)
112-116
: [scratchpad]The destination path for firstboot.conf is correct.
The review comment incorrectly assumes that
.not_logged_in_yet
should be a separate marker file and thatfirstboot.conf
should be copied to a different location.Analysis of the
armbian-firstlogin
script shows that/root/.not_logged_in_yet
serves a dual purpose:
- Its presence triggers the first-login logic (checked at line 613:
if [[ -f /root/.not_logged_in_yet && -n $(tty) ]]; then
)- It contains bash variable definitions that are sourced (line 93:
source "$fp_config"
) to configure the automated setupThe script validates and sources this file as a bash script (lines 87-93), loading
PRESET_*
variables. Thepreset-firstrun.sh
extension demonstrates this pattern by writing configuration variables directly to.not_logged_in_yet
(lines 4-51).Therefore, overwriting the empty marker file created at line 110 with the user's
firstboot.conf
at line 115 is the intended behavior.Likely an incorrect or invalid review comment.
Description
Inserting
firstboot.conf
fromuserpatches/
folder.Documentation summary for feature / change
Config usage: https://docs.armbian.com/User-Guide_Autoconfig/
How Has This Been Tested?
Checklist: