-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
prepare-host.sh: correct host dependency chain (Closes: #8779) #8781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
let debootstrap (which is the real dependency we have) pull in wget instead of having a hard and direct depency on it https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1118384#10
WalkthroughThis pull request modifies the host preparation dependencies in Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes The changes are localized to a single configuration file with straightforward dependency list modifications. Review complexity is minimal as it involves verifying that the added Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)lib/functions/host/prepare-host.sh (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This would be installing a package we don't actually use in the process. The one that comes with a distro might - in theory - have different dependencies as the one we actually use - from git. I would say we rather continue managing dependencies on our own. There are not many of them and it worked well for years. We could only add a note to the code why / where wget is needed. |
That confuses me. Are you saying that somewhere you download a wget from git(hub, I assume)? |
Yes, this is absolutely necessary as our build framework must be able to generate latest distributions, which are usually absent or broken with https://github.com/armbian/build/blob/main/lib/functions/rootfs/rootfs-create.sh#L60-L78 |
let debootstrap (which is the real dependency we have) pull in wget instead of having a hard and direct depency on it
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1118384#10