-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
opi5plus - board config maintenance #8787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConsolidates branch-specific U-Boot handlers for Orange Pi 5 Plus into a single function Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-09-11T06:12:54.213Z
Applied to files:
📚 Learning: 2025-10-14T05:08:11.785Z
Applied to files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
config/boards/orangepi5-plus.conf
(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
📚 Learning: 2025-09-11T06:12:54.213Z
Learnt from: SuperKali
PR: armbian/build#8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:12:54.213Z
Learning: In the Armbian build system, board family configuration files (like config/sources/families/rk35xx.conf) can inherit kernel branch definitions from common include files (like config/sources/families/include/rockchip64_common.inc). Even if a branch like "edge" is not defined directly in the family conf file, it may be available through the sourced include file.
Applied to files:
config/boards/orangepi5-plus.conf
📚 Learning: 2025-10-14T05:08:11.785Z
Learnt from: EvilOlaf
PR: armbian/build#8754
File: config/boards/bestv-r3300-l.csc:14-16
Timestamp: 2025-10-14T05:08:11.785Z
Learning: In the Armbian build system, BOOTBRANCH_BOARD is a valid framework variable used as a fallback when BOOTBRANCH is unset. The framework checks BOOTBRANCH_BOARD before applying the default bootloader branch value (see config/sources/common.conf). Board configuration files can use BOOTBRANCH_BOARD to specify the bootloader branch.
Applied to files:
config/boards/orangepi5-plus.conf
🔇 Additional comments (3)
config/boards/orangepi5-plus.conf (3)
56-56
: Good consolidation of gating logic.The updated gating logic now consistently skips vendor branch in both functions, which is cleaner and more maintainable than the previous approach.
60-62
: Verify that ARM crypto options work correctly.The PR testing notes indicate that boots were performed "without crypto options," but these changes enable ARMV8_CRYPTO, ARMV8_CE_SHA1, and ARMV8_CE_SHA256. Please confirm that these crypto acceleration features work correctly with the new U-Boot version, or clarify whether additional testing is planned before merge.
39-40
: No issues found — v2025.10 patch directory exists and is ready.Verification confirms the
patch/u-boot/v2025.10/
directory contains 33 patches, including board-specific patches and general fixes. The version bump in lines 39-40 is properly supported.
actually self-explaining I think
✅ This PR has been reviewed and approved — all set for merge! |
Do not merge yet. I want to test with crypto enabled later today unless @alexl83 is faster. |
https://paste.armbian.de/unohaqutuv.yaml seems fine |
✅ This PR has been reviewed and approved — all set for merge! |
next step would be eliminating vendor uboot altogether. I have a vendor kernel on nvme and mainline uboot on SPI. Works just fine. @efectn what do you think? Anything that might be missing in mainline uboot which is there in stone-age vendor? |
If I remember, some vendor kernel DTs assumed that vendor u-boot will have had brought up some regulators (npu?) so those things might fail. Unsure if it applies to OPi5's... |
Is it specific to npu or also affecting vpu etc.? I suppose there might be also some problems related to mac addresses, but i don't think it is also static in vendor uboot too |
Description
Note: It might be possible to get rid of vendor uboot altogether. Needs further testing though.
How Has This Been Tested?
Checklist: