Skip to content

Conversation

@stefanfoulis
Copy link

@stefanfoulis stefanfoulis commented Apr 14, 2017

WIP: do not merge yet

This is an experimental PR that still has many open questions.

Adds the option to keep the content inside the comment plugin visible.

Use cases:

  • Toggle visibility of blocks of content without having to move plugins
    in and out of the inline comment plugin.
  • Add a textual inline comment to a block of content that is visible on
    the page.

screen shot 2017-04-14 at 23 08 10

  • The plugin template now has a bunch of whitespace in it. I think it makes the template much more readable. I can make it more compact again, if requested.
  • I'm not sure about the styling yet. And should we add an indicator in the text of the plugin to show if it is hidden or visible? starting with django-cms 3.5 the method used to style won't work anymore
  • Translations
  • Add shortcut to toggle visibility into the plugins hamburger menu
  • Update tests

screen shot 2017-04-14 at 23 54 57

  • Figure out text/icon for quick visibility toggle in hamburger menu

Adds the option to keep the content inside the comment plugin visible.

Use cases:

* Toggle visibility of blocks of content without having to move plugins 
  in and out of the inline comment plugin.
* Add a textual inline comment to a block of content that is visible on
  the page.
Adds a quick access link in the hamburger menu of the plugin in 
structure mode that quickly switches the visibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant