[NOISSUE] use input validation to test API token/server credentials #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdzh-atlassian
requested review from
akalia-atlassian,
bhorai-atl,
bwieger-atlassian-com,
cabella-dot,
marcomura,
om-ukr and
pastelsky
as code owners
2 tasks
sdzh-atlassian
commented
Aug 30, 2025
| input.validationMessage = errorMessage || undefined; | ||
| }); | ||
| } | ||
| if (props.debounceValidationMs) { |
There was a problem hiding this comment.
Just removing the extra conditional here since it prevented validationMessage reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
This is kind of a proposed enhancement? Feel free to merge, nuke or iterate :)
This PR introduces the 1st part of our credential-saving logic as validation on the password input - basically, when user hits
enter, we try to ping/rest/api/2/myselfwith the assembled credentials first, and show an error message if it fails.There are 2 alternatives to this:
Works for API token:
Works for server auth - although we might need to do the special ssl/path settings before password for this to work in all cases:
How Has This Been Tested?
Tried this against API token and server auth with instenv - in case of the server auth, the correct input takes a bit of time and correctly shows the loading state
Basic checks:
npm run lintnpm run test