Fix flash_offset collision in mix.exs
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the mix.exs `flash_offset` option to include the platform name, to allow configuring an application for both esp32 and stm32 platforms in the mix.exs file. The original name is retained for command line over-rides. closes atomvm#30 Signed-off-by: Winford <winford@object.stream>
petermm
approved these changes
Nov 20, 2024
|
This has been approved already but maybe good to add some comment explaining the difference in flash_address between the elixir and non-elixir images? |
Other than being more explicit about needing to use an elixir support image, I think any reference to the offset used in the Erlang only images would lead to more confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the mix.exs
flash_offsetoption to include the platform name, to allow configuring an application for both esp32 and stm32 platforms in the mix.exs file. The original name is retained for command line over-rides.closes #30