Managed daemons networking changes, to manage daemon-bridge network m… #4815
Conversation
aviral92
requested review from
JoseVillalta and
xxx0624
and removed request for
a team
aviral92
force-pushed
the
managed-daemons-networking
branch
from
5cc9de0 to
94e91f3
Compare
|
|
||
| netInt.Default = true | ||
| netInt.DesiredStatus = status.NetworkReadyPull | ||
| netInt.KnownStatus = status.NetworkNone |
There was a problem hiding this comment.
I'm pretty sure we don't need to do this (line 400-401) the Fargate Agent State Machine looks at Namespace Manager Status not interface status directly. So this is unused at best. Worst case this ENI represents the host (primary) ENI, which is already up an running at this point, so we don't want to configure this ENI again. This is probably my fault, I added this code in a branch.
The other thing, the new call in line 391 initializes these attributes anyway.
The purpose for this method is to create a namespace config for the Fargate agent so that it can create a netns manager. For network namespace config known and desired status (line 411 and 412) this code is correct, for network interface let's do the same thing we do for host mode (init the struct directly) buildDefaultNetworkNamespaceConfig line 224. Let's double check two's repo to be sure.
JoseVillalta
left a comment
JoseVillalta
left a comment
There was a problem hiding this comment.
left a comment in CreateNetNs
4 participants
…ode.
Summary
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.