-
Notifications
You must be signed in to change notification settings - Fork 65
chore: Migrate CodeBuild release to GHA (without publishing step) #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
| fetch-depth: 0 | ||
| submodules: true | ||
|
|
||
| - name: Setup Node.js 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what the CodeBuild uses today
| NPM_CONFIG_UNSAFE_PERM: true | ||
|
|
||
| jobs: | ||
| compliance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need to come first? Can we break this up maybe? To have the publishing things come first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some validations to come first:
- Pre-publish validation that the head of main is healthy
- Publish
- Post-publish validation on the published artifact
Issue #, if available:
Description of changes:
Translate this package's the CodeBuild release workflow to GHA.
Today we publish to npm with legacy tokens which are slated to be removed sometime next week.
Suggested alternatives are
Testing: Had a previous commit that ran this workflow on PRs: https://github.com/aws/aws-encryption-sdk-javascript/actions/runs/19046654780/job/54400214440?pr=1614
Successful except for browser test vectors failure, whose failure reason is documented in workflow comments.
The next PR would add publishing.
The current CodeBuild publishing steps are not what we would use in GHA, so I won't copy them over.
CodeBuild uses OTP to publish, but GHA would follow these steps.
I'm keeping that out of scope for this "translation" PR so the new publishing steps would be easier to see.
(Also bump testing timeout -- 2s was timing out while loading AWS SDK, bump to 5s seems to work)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: