Skip to content

Conversation

BlakeLazarine
Copy link
Contributor

Problem

There are some cases where the session.modelId field is empty. When this happens, code review tool was failing unnecessarily. If modelId is null for us, then there is no issue

Solution

mark modelId as optional in schema

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BlakeLazarine BlakeLazarine requested a review from a team as a code owner September 29, 2025 23:35
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.93%. Comparing base (961e6ca) to head (e2ddb13).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   59.93%   59.93%           
=======================================
  Files         258      258           
  Lines       58244    58244           
  Branches     3553     3553           
=======================================
  Hits        34907    34907           
  Misses      23271    23271           
  Partials       66       66           
Flag Coverage Δ
unittests 59.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants