feat: enable datadog apm tracing #32
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
commented
Oct 20, 2025
crates/ingress-rpc/src/service.rs
Outdated
| if let Err(e) = self.queue.publish(&bundle, sender).await { | ||
| let span = | ||
| span!(tracing::Level::INFO, "span_publish", transaction = %transaction.tx_hash()); | ||
| if let Err(e) = self.queue.publish(&bundle, sender).instrument(span).await { |
There was a problem hiding this comment.
i can see the span! info logs but they don't show up as traces
There was a problem hiding this comment.
hoping that opentelemetry_datadog is the fix to sending traces to the agent properly ... will verify
wlawt
commented
Oct 21, 2025
| #[derive(Debug, Clone)] | ||
| struct AgentBasedSampler; | ||
|
|
||
| impl ShouldSample for AgentBasedSampler { |
There was a problem hiding this comment.
with this addition, it now brings back the error:
Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.
prior to implementing ShouldSample trait, it didn't panic.
in both scenarios, traces are still not showing up in APM though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #22 , #29
Overview
Distributed tracing will let us visualize in a flamegraph format of where a txn spends the most time in TIPS.
This would be particularly helpful in terms of optimizing certain TIPS components.
Resources
References
TODOs