Skip to content

Conversation

@BalboBegins
Copy link

What changed? Why?

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

Added error handler for ConnectWallet component in RegistrationButton.tsx.

- If wallet connection fails, an error notification is shown to users (using toast or console).
- The error is also logged for diagnostics and debugging purposes.

This improves user experience when a wallet connection error occurs and helps maintainers observe and fix issues related to wallet connecting.

Changes:
- Added handleConnectWalletError function.
- Passed onError prop to ConnectWallet for handling errors.
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Oct 22, 2025

@BalboBegins is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants