- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 636
 
feat(gazelle): Add python_generate_pyi_srcs directive #3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            dougthor42
  wants to merge
  11
  commits into
  bazel-contrib:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
dougthor42:u/dthor/gazelle-pyi_srcs-gh3354
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            feat(gazelle): Add python_generate_pyi_srcs directive #3356
                    dougthor42
  wants to merge
  11
  commits into
  bazel-contrib:main
from
dougthor42:u/dthor/gazelle-pyi_srcs-gh3354
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    6dc8a0e    to
    7a7f1d3      
    Compare
  
    
              
                    dougthor42
  
              
              commented
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
              
                    dougthor42
  
              
              commented
              
                  
                    Oct 21, 2025 
                  
              
              
            
            
| ### Fixed | ||
| * (gazelle) Remove {obj}`py_binary` targets with invalid `srcs`. This includes files | ||
| that are not generated or regular files. | ||
| * Nothing fixed. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally put this in the wrong section in #3046 🙃. I fix.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #3354
This adds a new Gazelle directive
python_generate_pyi_srcswhich accepts a boolean value
trueorfalse. It defaultsto
falsefor backwards compatibility.When
true, the directive causes.pyifiles, whose name matcheswith a .py file found in
srcs, to be added to thepyi_srcstarget attribute.
This helps with cases where manually-generated
.pyifiles arepresent in the project and are needed for things such as rules_mypy.
Given the following files in a
my_dirpackage:# gazelle:python_generate_pyi_srcs truewill cause Gazelle togenerate: