Skip to content

Conversation

thejohnfreeman
Copy link
Collaborator

I moved the changes to a branch, killing the old pull request. This way you can rebase onto master for a clean log if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this philosophy statement! I'm not 100% sure what "packaged" or "imported" mean in this context, but I'm willing to believe them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty fuzzy, and I think we can really improve the language here. Maybe:

A configuration can be packaged and imported, but data cannot.
Unlike data, a configuration has a fixed size and structure and can easily be expressed in code.

@sampsyo
Copy link
Member

sampsyo commented Apr 12, 2015

This is looking great! I've read a portion so far before needing to head out; I'll be sure to get back to this soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organizational note: perhaps the from_* functions, which return configurations, should get a separate section from these other source-finding utilities.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely.

@sampsyo
Copy link
Member

sampsyo commented Apr 13, 2015

This is looking great! We're definitely on the right track.

For the next few steps, would you rather work in your fork (I send pull requests there) or create a "v2" branch here (and I'll still use pull requests from "feature branches" to get your feedback)?

@thejohnfreeman
Copy link
Collaborator Author

I'd rather work in my fork and let you pull things in as you like. I've started work on the implementation, I think I can have a prototype in a few days, as I find time. I'll try to port the tests too.

@sampsyo
Copy link
Member

sampsyo commented Apr 13, 2015

OK, sounds great. I may even send pull requests your way while we're still living in the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants