Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Conversation

toby-griffiths
Copy link

This is because the require_php() method did not see a minor version as the same as the latest patch version, but php::version then tries to add the duplicate definitions.

This is because the require_php() method did not see a minor version as the same as the latest patch version, but php::version then tries to add the duplicate definitions
@toby-griffiths
Copy link
Author

I think that it would be better to move the calculation of the patch version from the minor version that's used to calculate the patch version at the top of the version.pp file into a common place, however I've no real knowledge of Ruby/Puppet, so wouldn't know how to go about this. Happy to learn & do with some guidance though.

@sambauers
Copy link

I've started a new PR at #82 to cover this problem. I haven't attempted the APC fix though. Suggest we close this and start a new one for APC once the other is merged.

@toby-griffiths
Copy link
Author

Happy to go with whatever, @sambauers.

Any thoughts on how to consolidate the version checking code so we're not copy/pasting everywhere?

@sambauers
Copy link

Pretty sure #82 is about as DRY as it's going to get.

We could write a generic extension building function, but I suspect the exceptions would make that messy pretty quickly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants