Skip to content

Conversation

@iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Sep 17, 2025

Based on #7116
Close #7171

@iequidoo iequidoo requested review from Hocuri and link2xt September 17, 2025 10:01
@link2xt
Copy link
Collaborator

link2xt commented Sep 17, 2025

#7116 already has migration 134, so this is better rebased on top of #7116 as @hpk42 already installed #7116 (never a good idea to test PRs with migrations on a live account, but well)

@iequidoo iequidoo force-pushed the iequidoo/delete-configured branch from b37c3e5 to fcea0cf Compare September 18, 2025 04:02
@iequidoo iequidoo changed the base branch from main to link2xt/ykltkokxntvk September 18, 2025 04:03
@iequidoo
Copy link
Collaborator Author

#7116 already has migration 134, so this is better rebased on top of #7116 as @hpk42 already installed #7116 (never a good idea to test PRs with migrations on a live account, but well)

It's fine if you don't install a PR with a migration on all your devices to have a way to recover. Otherwise if two people decided to test two different PRs with migrations, there's no way to recover

@link2xt link2xt force-pushed the link2xt/ykltkokxntvk branch from 5051240 to f1121da Compare October 15, 2025 17:16
@link2xt link2xt force-pushed the iequidoo/delete-configured branch from fcea0cf to bc88cc2 Compare October 15, 2025 17:16
@link2xt link2xt force-pushed the link2xt/ykltkokxntvk branch from f1121da to f6c2ada Compare October 16, 2025 02:59
@link2xt link2xt force-pushed the iequidoo/delete-configured branch from bc88cc2 to 618040a Compare October 16, 2025 02:59
@link2xt link2xt force-pushed the link2xt/ykltkokxntvk branch 2 times, most recently from a70866e to e60632e Compare October 16, 2025 23:06
@link2xt link2xt force-pushed the iequidoo/delete-configured branch from 618040a to be91790 Compare October 16, 2025 23:06
@link2xt link2xt force-pushed the link2xt/ykltkokxntvk branch 2 times, most recently from 9abbe7a to afc74b0 Compare October 19, 2025 11:35
Base automatically changed from link2xt/ykltkokxntvk to main October 19, 2025 11:49
@link2xt link2xt force-pushed the iequidoo/delete-configured branch from be91790 to bd6001c Compare October 23, 2025 14:25
@link2xt

This comment was marked as resolved.

@Hocuri
Copy link
Collaborator

Hocuri commented Oct 23, 2025

But this PR here doesn't even touch ConfiguredAddr, so, I think it's fine?

We do need to keep ConfiguredAddr for now, because it's used to remember which transport is the primary transport; grepping for "ConfiguredAddr" yields 33 results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After updating my password, the old password is still stored in the database

5 participants