Close underlying file more naturally; init size without reading file #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added RangedFileReader.close() method, which allows underlying StreamingHttpResponse to add to `_closable_objects` more naturally to fix unclosed files. Also initialized `RangedFileReader.size` using `file_like.size` property (if available, i.e. Django File/FieldFile) rather than reading entire file contents.
No longer need to add file to `_closable_objects` explicitly with new reader close() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behaviour
Underlying file object should get closed when the response gets closed. The underlying
StreamingHttpResponseshould add theRangedFileReaderto the_closable_objectslist.Actual behaviour
Without a
RangedFileReader.close()method, theStreamingHttpResponsedoesn't see theRangedFileReader(and its underlying file) as a closable object. The previous version also marked to close the file, but had to do it explicitly.Description of fix
_closable_objectsmore naturally to fix unclosed files without explicitly adding underlying file to the closable list.RangedFileReader.sizeusingfile_like.sizeproperty (if available, i.e. Django File/FieldFile) rather than reading entire file contents.