WIP: Debug: Enable VM debug console #658

mcastelino · 2017-09-30T00:48:00Z

Enable the VM debug console whenever the VM Kernel debug
is enabled.

Fixes: #559.

Has a dependency on having a updated agent being installed in the container rootfs to add the new systemd services.

clearcontainers/agent#122

Signed-off-by: Manohar Castelino manohar.r.castelino@intel.com

clearcontainersbot · 2017-09-30T01:21:28Z

kubernetes qa-passed 👍

grahamwhaley

lgtm

grahamwhaley · 2017-10-02T08:42:49Z

CI is failing though. I suspect we probably have a vendor or merge dep? In f26 we have:

../../../go/src/github.com/clearcontainers/runtime/list.go:84: undefined: defaultRootDirectory
../../../go/src/github.com/clearcontainers/runtime/main.go:91: undefined: defaultRootDirectory
../../../go/src/github.com/clearcontainers/runtime/config.go:146: too many errors

jodh-intel · 2017-10-02T08:44:47Z

Hmm, actually the CI run was successful for all 3 runs. Looks like there might be an issue with the jenkins-github plugin @sboeuf ?

jodh-intel · 2017-10-02T08:46:01Z

@grahamwhaley - the undefined errors are caused by the jenkins scripts incorrectly go get'ing the runtime code (it should be go get -d). Hopefully we can resolve that once clearcontainers/jenkins#10 lands.

clearcontainersbot · 2017-10-03T10:43:10Z

kubernetes qa-passed 👍

clearcontainersbot · 2017-10-03T18:45:35Z

kubernetes qa-passed 👍

clearcontainersbot · 2017-10-06T19:50:26Z

kubernetes qa-passed 👍

jodh-intel · 2017-10-09T11:14:38Z

Hi @mcastelino - this requires an update to the tests. From the CI logs:

./create_test.go:848: cannot use func literal (type func(string) []virtcontainers.Param) as type func(string, oci.RuntimeConfig) []virtcontainers.Param in assignment

clearcontainersbot · 2017-10-09T19:03:22Z

kubernetes qa-passed 👍

Enable the VM debug console whenever the VM Kernel debug is enabled. Fixes: clearcontainers#559. Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>

clearcontainersbot · 2017-10-09T21:54:20Z

kubernetes qa-passed 👍

jodh-intel · 2017-10-10T08:34:44Z

lgtm

jodh-intel · 2017-10-11T13:52:42Z

docs/debug-kernel.md

+   for further debug.
+
+   ```
+   socat /run/virtcontainers/pods/<pod id>/console.sock


Can you add a $ prompt for consistency with the rest of the doc please. Also, presumably we need a sudo in there too?

@iphutch - please can you review these doc changes?

jodh-intel · 2017-10-16T08:43:12Z

Hi @mcastelino - just one final nit in the docs from me.

@iphutch - please could you review the doc changes?

iphutch · 2017-10-16T15:38:31Z

docs/debug-kernel.md

   This will result in the `cc-proxy` log being printed on the terminal. This method
   can also be used to capture the logs in a specific `cc-proxy` file.
+
+5. Connect to the Virtual machine console


Use all lower case:
s/Virtual/virtual

iphutch · 2017-10-16T15:39:42Z

docs/debug-kernel.md

+   for further debug.
+
+   ```
+   socat /run/virtcontainers/pods/<pod id>/console.sock


iphutch · 2017-10-16T15:43:55Z

docs/debug-kernel.md

+
+5. Connect to the Virtual machine console
+
+   If the kernel boots successfully then the virtual machine console can be accessed


We should avoid using an "if" clause unless we provide options for when the kernel does not boot successfully.
Let us ensure that our instructions are accurate and assume the reader has followed the instructions exactly:
After the kernel boots, the virtual machine console can be accessed for further debugging.

clearcontainersbot · 2017-10-21T03:14:15Z

kubernetes qa-failed 👎

jodh-intel · 2017-10-24T09:00:34Z

Hi @mcastelino - just a reminder that this PR needs a few minor tweaks.

clearcontainersbot · 2017-10-28T20:54:19Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-10-30T09:27:49Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-11-01T05:10:46Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-11-23T20:15:58Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-12-14T05:46:53Z

kubernetes qa-failed 👎

jodh-intel · 2017-12-18T13:28:23Z

Hi @klynnrif, @rcaballeromx - I'm assuming @iphutch won't be able to complete this review so could one of you take a look and if you're happy, we'll force-merge this as we will have the requisite doc team approval.

klynnrif · 2017-12-19T18:40:23Z

@jodh-intel @rcaballeromx the suggestions @iphutch made lgtm. All good to me with those changes. Thanks!

clearcontainersbot · 2017-12-21T13:03:46Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-04T09:17:01Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-09T12:22:38Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-10T11:59:22Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-15T11:07:40Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-18T10:39:24Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-24T11:31:48Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-29T18:36:58Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-01-31T11:00:54Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-02-07T16:19:41Z

kubernetes qa-failed 👎

clearcontainersbot · 2018-02-09T13:32:05Z

kubernetes qa-failed 👎

amyleeland added the in progress label Sep 30, 2017

grahamwhaley mentioned this pull request Oct 2, 2017

Debug: Provide a way to enable a debug console to the VM clearcontainers/agent#122

Open

grahamwhaley approved these changes Oct 2, 2017

View reviewed changes

mcastelino force-pushed the topic/debug_console branch from 44af25c to f28f5a2 Compare October 6, 2017 17:25

mcastelino force-pushed the topic/debug_console branch from f28f5a2 to 53c685c Compare October 9, 2017 18:37

Debug: Enable VM debug console

b59bfde

Enable the VM debug console whenever the VM Kernel debug is enabled. Fixes: clearcontainers#559. Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>

mcastelino force-pushed the topic/debug_console branch from 53c685c to b59bfde Compare October 9, 2017 19:48

jodh-intel reviewed Oct 11, 2017

View reviewed changes

iphutch suggested changes Oct 16, 2017

View reviewed changes

jodh-intel mentioned this pull request Jan 12, 2018

Runtime hangs after cycling instances with qemu-cc #910

Closed

jodh-intel mentioned this pull request Mar 14, 2018

Discuss introducing a debug console facility kata-containers/agent#169

Closed


		5. Connect to the Virtual machine console

		If the kernel boots successfully then the virtual machine console can be accessed

WIP: Debug: Enable VM debug console #658

Are you sure you want to change the base?

WIP: Debug: Enable VM debug console #658

Uh oh!

Conversation

mcastelino commented Sep 30, 2017

Uh oh!

clearcontainersbot commented Sep 30, 2017

Uh oh!

grahamwhaley left a comment

Choose a reason for hiding this comment

Uh oh!

grahamwhaley commented Oct 2, 2017

Uh oh!

jodh-intel commented Oct 2, 2017

Uh oh!

jodh-intel commented Oct 2, 2017

Uh oh!

clearcontainersbot commented Oct 3, 2017

Uh oh!

clearcontainersbot commented Oct 3, 2017

Uh oh!

clearcontainersbot commented Oct 6, 2017

Uh oh!

jodh-intel commented Oct 9, 2017

Uh oh!

clearcontainersbot commented Oct 9, 2017

Uh oh!

clearcontainersbot commented Oct 9, 2017

Uh oh!

jodh-intel commented Oct 10, 2017 • edited by grahamwhaley Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jodh-intel Oct 11, 2017

Choose a reason for hiding this comment

Uh oh!

iphutch Oct 16, 2017

Choose a reason for hiding this comment

Uh oh!

jodh-intel commented Oct 16, 2017

Uh oh!

iphutch Oct 16, 2017

Choose a reason for hiding this comment

Uh oh!

iphutch Oct 16, 2017

Choose a reason for hiding this comment

Uh oh!

iphutch Oct 16, 2017

Choose a reason for hiding this comment

Uh oh!

clearcontainersbot commented Oct 21, 2017

Uh oh!

jodh-intel commented Oct 24, 2017

Uh oh!

clearcontainersbot commented Oct 28, 2017

Uh oh!

clearcontainersbot commented Oct 30, 2017

Uh oh!

clearcontainersbot commented Nov 1, 2017

Uh oh!

clearcontainersbot commented Nov 23, 2017

Uh oh!

clearcontainersbot commented Dec 14, 2017

Uh oh!

jodh-intel commented Dec 18, 2017

Uh oh!

klynnrif commented Dec 19, 2017

Uh oh!

clearcontainersbot commented Dec 21, 2017

Uh oh!

clearcontainersbot commented Jan 4, 2018

Uh oh!

clearcontainersbot commented Jan 9, 2018

Uh oh!

clearcontainersbot commented Jan 10, 2018

Uh oh!

clearcontainersbot commented Jan 15, 2018

Uh oh!

clearcontainersbot commented Jan 18, 2018

Uh oh!

jodh-intel commented Oct 10, 2017 •

edited by grahamwhaley

Loading