Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-wombats-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/backend': minor
---

Allow reading proto and host for proxied requests from a custom header besides X-Forwarded-Proto and X-Forwarded-Host
31 changes: 31 additions & 0 deletions packages/backend/src/tokens/__tests__/clerkRequest.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,37 @@ describe('createClerkRequest', () => {
expect(createClerkRequest(req).clerkUrl.toString()).toBe('https://example.com/path');
});

it('with forwarded proto / host headers overridden via env vars', () => {
const originalForwardedProto = process.env.CLERK_PROXY_FORWARDED_PROTO_HEADER;
const originalForwardedHost = process.env.CLERK_PROXY_FORWARDED_HOST_HEADER;

process.env.CLERK_PROXY_FORWARDED_PROTO_HEADER = 'x-my-forwarded-proto';
process.env.CLERK_PROXY_FORWARDED_HOST_HEADER = 'x-my-forwarded-host';

const req = new Request('http://localhost:3000/path', {
headers: {
'x-my-forwarded-host': 'example.com',
'x-my-forwarded-proto': 'https',
},
});

try {
expect(createClerkRequest(req).clerkUrl.toString()).toBe('https://example.com/path');
} finally {
if (originalForwardedProto === undefined) {
delete process.env.CLERK_PROXY_FORWARDED_PROTO_HEADER;
} else {
process.env.CLERK_PROXY_FORWARDED_PROTO_HEADER = originalForwardedProto;
}

if (originalForwardedHost === undefined) {
delete process.env.CLERK_PROXY_FORWARDED_HOST_HEADER;
} else {
process.env.CLERK_PROXY_FORWARDED_HOST_HEADER = originalForwardedHost;
}
}
});

it('with path in request', () => {
const req = new Request('http://localhost:3000/path');
expect(createClerkRequest(req).clerkUrl.toString()).toBe('http://localhost:3000/path');
Expand Down
14 changes: 12 additions & 2 deletions packages/backend/src/tokens/clerkRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,18 @@ class ClerkRequest extends Request {
*/
private deriveUrlFromHeaders(req: Request) {
const initialUrl = new URL(req.url);
const forwardedProto = req.headers.get(constants.Headers.ForwardedProto);
const forwardedHost = req.headers.get(constants.Headers.ForwardedHost);

// When Clerk is served behind a proxy, it determines the protocol and host of the request
// by looking at the request headers.
// The default values are "X-Forwarded-Proto" and "X-Forwarded-Host" respectively, but the
// header names can be overwritten via env vars.
const forwardedProto = req.headers.get(
process.env.CLERK_PROXY_FORWARDED_PROTO_HEADER || constants.Headers.ForwardedProto,
);
const forwardedHost = req.headers.get(
process.env.CLERK_PROXY_FORWARDED_HOST_HEADER || constants.Headers.ForwardedHost,
);

const host = req.headers.get(constants.Headers.Host);
const protocol = initialUrl.protocol;

Expand Down