Skip to content

Conversation

@panteliselef
Copy link
Member

@panteliselef panteliselef commented Oct 24, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Updated integration test matrix: removed the default "quickstart" entry, added a Next.js v16 test variant, and introduced Quickstart scenarios for Next.js v15 and v16. This expands observable test-name / Next.js-version / test-project combinations in CI while keeping existing workflow behavior unchanged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: de2313a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Oct 24, 2025 2:58pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Walkthrough

Updated the CI integration-tests matrix to remove quickstart from the default list and add matrix include entries for nextjs with next-version: 16 and quickstart with next-version: 15 and 16, creating additional test-name/next-version combinations.

Changes

Cohort / File(s) Change Summary
CI Workflow Configuration
/.github/workflows/ci.yml
Removed quickstart from the main test-name matrix and added matrix include entries for nextjs with next-version: 16 and quickstart with next-version: 15 and 16, expanding integration-test combinations without other workflow logic changes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer (PR)
    participant GH as GitHub Actions
    participant Matrix as Test Matrix
    participant Job as Integration Test Job
    Note over Dev,GH:#DDEBF7 PR triggers CI workflow
    Dev->>GH: push PR
    GH->>Matrix: evaluate matrix (includes updated)
    Note right of Matrix:#E8F5E9 Matrix now includes: nextjs@16, quickstart@15, quickstart@16
    Matrix->>Job: spawn jobs for each combination
    Job->>Job: run integration tests
    Job-->>GH: report results
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through YAML, small and spry,
Added versions for tests to try.
Nextjs and quickstart join the spree,
Little matrix hops — hooray for me! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "chore(repo): Run next e2e tests against v16" directly and clearly relates to the main change in the changeset. The raw summary shows that the CI workflow was modified to add Next.js v16 to the e2e test matrix (under include), which is precisely what the title communicates. The title is concise, uses conventional commit format appropriately, and is specific enough that a teammate reviewing the git history would immediately understand the primary objective. The title appropriately matches the changes made to the workflow configuration without being vague or generic.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch elef/enable-next-16-tests

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e51586c and de2313a.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@panteliselef panteliselef changed the title chore(ci): Run next e2e tests against v16 chore(repo): Run next e2e tests against v16 Oct 24, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7066

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7066

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7066

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7066

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7066

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7066

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7066

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7066

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7066

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7066

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7066

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7066

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7066

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7066

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7066

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7066

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7066

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7066

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7066

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7066

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7066

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7066

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7066

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7066

commit: de2313a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants