- 
                Notifications
    You must be signed in to change notification settings 
- Fork 16
build+ci: make local, gh, and Jenkins envs identical #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            dshemetov
  wants to merge
  24
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
ds/clean-clean-delphi-utils
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            24 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      69571ef
              
                add pyproject.toml
              
              
                aysim319 7936340
              
                made changes based on suggestion
              
              
                aysim319 341f3b1
              
                update ci config
              
              
                aysim319 4a58492
              
                separate new line
              
              
                aysim319 cbc7453
              
                fix: add explicit boto and moto dependencies to indicators
              
              
                dshemetov d88dba1
              
                trying to get package data to show
              
              
                aysim319 46496ce
              
                installing dev package before testing in ci
              
              
                aysim319 4129c98
              
                adding dependency
              
              
                aysim319 c920b55
              
                move comment to right package
              
              
                aysim319 068d4d0
              
                Update _delphi_utils_python/pyproject.toml
              
              
                aysim319 b80b3ea
              
                more suggestion
              
              
                aysim319 9fd531e
              
                adding pyproject.toml to template
              
              
                aysim319 755b671
              
                Update changehc/Makefile
              
              
                dshemetov 8f35aad
              
                Update claims_hosp/Makefile
              
              
                dshemetov bff5bb8
              
                Update doctor_visits/Makefile
              
              
                dshemetov 1e1ccaf
              
                Update google_symptoms/Makefile
              
              
                dshemetov e95b5d7
              
                Update hhs_hosp/Makefile
              
              
                dshemetov 4bc32d8
              
                Update nchs_mortality/Makefile
              
              
                dshemetov 1d8b1d4
              
                Update nssp/Makefile
              
              
                dshemetov cd44d90
              
                Update nwss_wastewater/Makefile
              
              
                dshemetov c2fdae5
              
                Update quidel_covidtest/Makefile
              
              
                dshemetov 45cfd8f
              
                Update sir_complainsalot/Makefile
              
              
                dshemetov 46ef13b
              
                fix: dependence bugs and cleanup
              
              
                dshemetov 8a72ca0
              
                build+ci+jenkins: make local, ci, and deploy envs identical
              
              
                dshemetov File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=70.1", "setuptools-scm>=8.0"] | ||
| build-backend = "setuptools.build_meta" | ||
|  | ||
| [project] | ||
| name = "delphi-utils" | ||
| version = "0.3.24" | ||
| description = "Shared Utility Functions for Indicators" | ||
| readme = "README.md" | ||
| requires-python = "== 3.8.*" | ||
| license = { text = "MIT License" } | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "Intended Audience :: Developers", | ||
| "Programming Language :: Python :: 3.8", | ||
| "License :: MIT", | ||
| ] | ||
| dependencies = [ | ||
| "boto3", | ||
| "covidcast", | ||
| "cvxpy", | ||
| "epiweeks", | ||
| "gitpython", | ||
| "importlib_resources>=1.3", | ||
| "numpy", | ||
| "pandas>=1.1.0", | ||
| "requests", | ||
| "slackclient", | ||
| "scs<3.2.6", # TODO: remove this ; it is a cvxpy dependency, and the excluded version appears to break our jenkins build. see: https://github.com/cvxgrp/scs/issues/283 | ||
| "structlog", | ||
| "xlrd", # needed by Pandas to read Excel files | ||
| ] | ||
|  | ||
| [project.urls] | ||
| Homepage = "https://github.com/cmu-delphi/covidcast-indicators" | ||
|  | ||
| [project.optional-dependencies] | ||
| dev = [ | ||
| "build[virtualenv]", | ||
| "darker[isort]~=2.1.1", | ||
| "pylint==2.8.3", | ||
| "pytest", | ||
| "pydocstyle", | ||
| "pytest-cov", | ||
| "mock", | ||
| "moto~=4.2.14", | ||
| "requests-mock", | ||
| "freezegun", | ||
| "twine" | ||
| ] | ||
| flash = ["scipy"] | ||
|  | ||
| [tool.setuptools.packages.find] | ||
| where = ["."] | ||
| include = ["delphi_utils"] | ||
| namespaces = true | ||
|  | ||
| [tool.setuptools.package-data] | ||
| "delphi_utils.data" = ["20*/*.csv"] | 
This file was deleted.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| [build-system] | ||
| requires = ["setuptools", "setuptools-scm>=8.0"] | ||
| build-backend = "setuptools.build_meta" | ||
|  | ||
| [project] | ||
| name = "delphi_NAME" | ||
| version = "0.1.0" | ||
| description = "SHORT DESCRIPTION" | ||
| readme = "README.md" | ||
| requires-python = "== 3.8.*" | ||
| license = { text = "MIT License" } | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "Intended Audience :: Developers", | ||
| "Programming Language :: Python :: 3.8", | ||
| "License :: MIT", | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. need to change this to "License :: OSI Approved :: MIT License"; fixing the merge conflict should fix this | ||
| ] | ||
| dependencies = [ | ||
| "delphi-utils", | ||
| "numpy", | ||
| "pandas>=1.1.0", | ||
| ] | ||
|  | ||
| [project.urls] | ||
| Homepage = "https://github.com/cmu-delphi/covidcast-indicators" | ||
|  | ||
| [project.optional-dependencies] | ||
| dev = [ | ||
| "darker[isort]~=2.1.1", | ||
| "pylint==2.8.3", | ||
| "pytest", | ||
| "pydocstyle", | ||
| "pytest-cov", | ||
| "mock", | ||
| "moto~=4.2.14", | ||
| "requests-mock", | ||
| "freezegun", | ||
| ] | ||
|  | ||
| [tool.setuptools.packages.find] | ||
| where = ["."] | ||
| namespaces = true | ||
This file was deleted.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -6,6 +6,7 @@ | |
| "covidcast", | ||
| "darker[isort]~=2.1.1", | ||
| "delphi-utils", | ||
| "mock", | ||
| "moto~=4.2.14", | ||
| "numpy", | ||
| "pandas", | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -6,6 +6,7 @@ | |
| "darker[isort]~=2.1.1", | ||
| "delphi-utils", | ||
| "numpy", | ||
| "pydocstyle", | ||
| "pandas", | ||
| "paramiko", | ||
| "pyarrow", | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -5,6 +5,7 @@ | |
| "darker[isort]~=2.1.1", | ||
| "delphi-utils", | ||
| "numpy", | ||
| "pydocstyle", | ||
| "pandas", | ||
| "paramiko", | ||
| "pylint==2.8.3", | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should keep this... I know previously we wanted to convert all the setup.py into pyproject.toml, but I rememeber the release where we converted delphi_utils setup.py into pyproject.toml has some hiccups....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some issues using the pyproject.toml for nhsn and ended up just using the setup.py. since this codebase will be replaced, I think it's better to keep setup.py and have it consistent with the other indicators