Split out redux from Music Lab timeline #69018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is largely the same as the original Timeline file, just with props instead of redux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the Music Lab timeline into a top level container that accesses the music lab redux state, and a UI-only presentation component (and subcomponents) that don't depend on any redux. This allows us to reuse the UI-only version in other contexts like on the Dance Party AI choreography levels, or in a Dance music mashup share view, etc. No functional changes.
Testing story
Tested locally to verify no functional changes. I also added a quick unit test to make sure we don't accidentally add back any redux to the UI components. We should ideally extend that unit test to actually test the timeline view and functionality, but I'll leave that for a later time.