Add pull request permissions and update install script in GitHub Actions workflow #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - name: Update install.sh | ||
| run: | | ||
| VERSION="${{ steps.version.outputs.version }}" | ||
| sed -i.bak "s/VERSION=\${CODECRAFTERS_CLI_VERSION:-v[0-9]*}/VERSION=\${CODECRAFTERS_CLI_VERSION:-$VERSION}/" install.sh |
There was a problem hiding this comment.
Bug: Unescaped Version Variable in Sed Command
The sed command in the update-install-script job uses the $VERSION variable unescaped in its replacement string. This can cause the command to fail or incorrectly modify install.sh if the version tag contains sed special characters like /, &, or \.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds a post-release job that updates the default CLI version in install.sh via an auto-generated PR and grants pull-requests write permission.
pull-requests: writetopermissionsin.github/workflows/publish.yml.update-install-script(runs aftergoreleaser):install.shto set defaultCODECRAFTERS_CLI_VERSIONto the new tag.peter-evans/create-pull-requestwith versioned branch and auto-delete.Written by Cursor Bugbot for commit 1672d3a. This will update automatically on new commits. Configure here.