-
Notifications
You must be signed in to change notification settings - Fork 0
refactor rules engine for key value structure with spec compliance #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bcpeinhardt
wants to merge
31
commits into
main
Choose a base branch
from
bcpeinhardt/simple-allow-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f743e6a.
bcpeinhardt
commented
Oct 25, 2025
| @@ -0,0 +1,232 @@ | |||
| package rulesengine | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has a set of integration tests that go through the full parse and match cycle that should illuminate the edge cases of how this syntax works 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An allow rule can have a single domain pattern, like
domain=google.com.Subdomains are automatic matches.
To require subdomains only, use
domain=*.github.com.An allow rule can have multiple method and path patterns, separated by commas, like
method=GET,HEADorpath=/wibble,/wibble/*.A trailing asterisk in a path pattern, like
/wibble/*, matches any number of trailing segments.A leading asterisk in a domain pattern, like
*.github.com, matches any number of subdomains. An asterisk in the middle of a domain or path pattern matches exactly one middle segment.I think this encourages specific concise rules around individual domains, like
--allow "domain=api.github.com method=GET,HEAD path=/repos/octocat/*/issues"P.S. I realize the line count is somewhat daunting but that is mostly tests.