🤖 Add workspace kebab menu with Fork and Compact modals #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace delete button with KebabMenu (Fork, Compact, Delete) - Add ForkWorkspaceModal with command display pattern - Add CompactModal with command display pattern - Export formatForkCommand and formatCompactCommand utilities - Maximize code reuse following /new + NewWorkspaceModal pattern Generated with `cmux`
- Move FormGroup, ErrorMessage, HelpText to shared exports - Move CommandDisplay and CommandLabel to shared exports - Update ForkWorkspaceModal, CompactModal, NewWorkspaceModal to use shared components - Eliminates ~180 lines of duplication Generated with `cmux`
Generated with `cmux`
- Rename internal execution types to avoid confusion - ForkOptions/CompactOptions are now user-facing types - ForkExecutionOptions/CompactExecutionOptions for internal use - Modals use options type directly as state - Eliminates intermediate object construction Generated with `cmux`
The deprecated function was just pointless indirection. Generated with `cmux`
- Remove formatForkCommand overloads (only ForkOptions signature needed) - Remove formatCompactCommand overloads (only CompactOptions signature needed) - Fix lint issues: - Remove unused Tooltip imports in WorkspaceListItem - Use nullish coalescing (??) instead of logical OR (||) in CompactModal - Fix missing dependencies in useEffect hook All call sites already use the options object signature.
- CompactExecutionOptions now extends CompactOptions - ForkOptions (execution) now extends UserForkOptions (base) - Moved UserForkOptions definition to workspaceFork.ts (source of truth) - Pass options object directly to formatCompactCommand (no reconstruction) - Eliminates field duplication and ensures type consistency
ammar-agent
force-pushed
the
workspace-kebab-menu
branch
from
eb68248 to
d6174fc
Compare
- Created useCompactOptions hook to centralize default model resolution - Both CompactModal and /compact command now use same model logic - Hook initializes with preferred compaction model from localStorage - Provides resetOptions() to reset form while preserving model preference - Simplifies useEffect dependencies in CompactModal Ensures consistent treatment of model defaults across modal and slash command paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the delete button on workspace items with a kebab menu containing Fork, Compact, and Delete actions. Adds modal experiences for Fork and Compact operations following the pattern established by
/newcommand and NewWorkspaceModal.Changes
New Components
Enhanced Functionality
Shared Utilities
formatForkCommand()- Generate/forkcommand string for displayformatCompactCommand()- Generate/compactcommand string for displayformatNewCommand()Implementation Details
Code Reuse Pattern
Maximizes code reuse by:
forkWorkspace()andexecuteCompaction()utilitiesGrid Layout
Updated WorkspaceListItem grid from
auto auto 1fr autotoauto auto 1fr auto autoto accommodate KebabMenu in 5th column.Modal Features
Both modals include:
Testing
Manual testing needed:
Generated with
cmux