🤖 Add custom prompt mentions (@) feature #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created prompt file utilities to search .cmux and ~/.cmux/prompts for markdown prompts - Added IPC channels for listing and reading prompts - Implemented @mention autocomplete in ChatInput with PromptSuggestions component - Prompts are expanded before sending to backend - Repo prompts (.cmux) take precedence over system prompts (~/.cmux/prompts) - Added comprehensive tests for prompt utilities Generated with `cmux`
Generated with `cmux`
Generated with `cmux`
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The previous implementation always replaced the last @ in the input, which caused issues when editing earlier mentions in a multi-mention message. Changes: - getPromptSuggestions now accepts cursor position parameter - Only considers @ before the cursor for suggestions - handlePromptSelect replaces the @ at cursor, not the last one - Added tests for cursor-aware behavior Resolves Codex review feedback. Generated with `cmux`
- Use RegExp#exec() instead of String#match() - Use optional chaining Generated with `cmux`
Generated with `cmux`
- Removed stray documentation file (PROMPTS_FEATURE.md) - Extracted getPromptDirectories() helper to eliminate duplication in ipcMain - Added comprehensive integration tests for prompts feature - Tests listing prompts from both system and repo directories - Tests repo prompts override system prompts - Tests reading prompt content - Tests handling of non-existent prompts - All 4 tests pass Generated with `cmux`
Generated with `cmux`
- Create usePrompts hook to manage all prompt-related state and logic - Remove 59 lines from ChatInput (950 -> 891 lines) - Hook handles: - Loading available prompts from workspace - Generating suggestions based on cursor position - Expanding @mentions to their content - Manual dismissal of suggestions - Improves separation of concerns and testability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for custom prompt mentions using the
@mentionsyntax in the chat input. Users can create reusable prompt templates as markdown files and reference them inline.Changes
.cmuxand~/.cmux/promptsfor markdown prompts@mentionautocomplete withPromptSuggestionscomponent.cmux) override system prompts (~/.cmux/prompts)Usage
@in the chat input to see available prompts@prompt-nameis replaced with prompt contentExamples
System prompts:
~/.cmux/prompts/explain.mdRepo prompts:
.cmux/review.mdSee
PROMPTS_FEATURE.mdfor full documentation.Generated with
cmux