🤖 Fix tool error display and WRITE DENIED collapse #414
+47
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two related UI issues with tool display:
Tool errors not displayed clearly: When an agent calls a tool that doesn't exist or is disabled by policy, the UI shows "Waiting for result..." indefinitely with no error indication.
WRITE DENIED collapse not working: PR 🤖 Collapse WRITE DENIED errors by default #403 added logic to collapse WRITE DENIED errors by default, but it doesn't work because the component renders before the result is available.
Solution
Tool Error Display
Updated
GenericToolCallandStreamingMessageAggregatorto handle both error formats:{ error: "..." }{ success: false, error: "..." }Changes:
WRITE DENIED Collapse
Fixed
FileEditToolCallto collapse when WRITE DENIED result arrives:useEffectto watch for result changesTesting
Generated with
cmux