-
-
Notifications
You must be signed in to change notification settings - Fork 302
feat: add config option for line length warning #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config option for line length warning #1574
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-2 #1574 +/- ##
=========================================
Coverage ? 98.71%
=========================================
Files ? 60
Lines ? 2655
Branches ? 0
=========================================
Hits ? 2621
Misses ? 34
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sorry, I accidentally closed this pull request. |
|
let's rebase from |
9a2622f to
c300b70
Compare
|
I have rebased my branch onto v4-9-0. |
You've done it perfectly 🙂 I'll take a look when bandwidth allow |
bearomorphism
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few suggestion:
|
we might need to resolve the conflict first. Thanks! |
|
Hi @Narwhal-fish , could you help to rebase your branch when you have a moment? You can run and then drop all commits but yours. |
de2e785 to
e70271b
Compare
a696b74 to
4adcbba
Compare
4adcbba to
3f55412
Compare
Description
This PR implements configuration file support for the
message_length_limitoption, addressing issue #1571 . Previously, users could only set commit message length limits via command-line arguments (-l/--message-length-limit). Now they can define a default limit in their configuration file.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Users can now set default commit message length limits in their configuration file:
Steps to Test This Pull Request
Additional Context