Skip to content

Conversation

@GlassOfWhiskey
Copy link
Contributor

@GlassOfWhiskey GlassOfWhiskey commented Nov 10, 2025

This commit discards all fields that are present in a cwl.output.json file but have not been declared in the outputs section of the related CommandLineTool, implementing common-workflow-language/cwl-v1.3#80.
Conformance tests for this update have been implemented in common-workflow-language/cwl-v1.3#81.

This commit discards all fields that are present in a `cwl.output.json`
file but have not been declared in the `output` object of the related
`CommandLineTool`, implementing common-workflow-language/cwl-v1.3#80.
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (766d58b) to head (dbfbfab).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   85.10%   85.13%   +0.02%     
==========================================
  Files          46       46              
  Lines        8358     8368      +10     
  Branches     1951     1956       +5     
==========================================
+ Hits         7113     7124      +11     
  Misses        779      779              
+ Partials      466      465       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c November 10, 2025 20:40
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add something like if ORDERED_VERSIONS.index(self.metadata[ORIGINAL_CWLVERSION]) >= ORDERED_VERSIONS.index("v1.3.0-dev1"): to only change behavior for CWL v1.3.0+
  • add tests here for the previous behavior using cwlVersion: v1.0, cwlVersion: v1.1, and cwlVersion: v1.2

Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
@GlassOfWhiskey
Copy link
Contributor Author

@mr-c as I wrote in the CWL v1.3 spec, I assumed undefined behavior for previous CWL versions, meaning that any implementation is free to do whatever it wants. Therefore, I am completely against putting conformance test for an undefined behavior just because cwltool did something, also because I am not sure what other implementations do in this particular use case.

Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
@mr-c
Copy link
Member

mr-c commented Nov 11, 2025

@GlassOfWhiskey I agree, I was asking for tests in cwltool, not new conformance tests. That way we don't break anything for cwltool users running a CommandLineTool directly. For CWL workflows I don't think there is a way to make use of the undeclared outputs, beyond them showing up in logs & provenance reports.

GlassOfWhiskey and others added 3 commits November 11, 2025 15:46
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
@mr-c mr-c force-pushed the fix-cwl-output-json branch from f8ba35d to dbfbfab Compare November 11, 2025 15:33
@mr-c mr-c marked this pull request as ready for review November 11, 2025 15:33
@mr-c mr-c enabled auto-merge (squash) November 11, 2025 15:35
@mr-c mr-c merged commit d7184c7 into main Nov 11, 2025
46 checks passed
@mr-c mr-c deleted the fix-cwl-output-json branch November 11, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants