-
-
Notifications
You must be signed in to change notification settings - Fork 237
Discard undeclared fields from cwl.output.json
#2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit discards all fields that are present in a `cwl.output.json` file but have not been declared in the `output` object of the related `CommandLineTool`, implementing common-workflow-language/cwl-v1.3#80.
9243f20 to
e1cbce7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
+ Coverage 85.10% 85.13% +0.02%
==========================================
Files 46 46
Lines 8358 8368 +10
Branches 1951 1956 +5
==========================================
+ Hits 7113 7124 +11
Misses 779 779
+ Partials 466 465 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add something like
if ORDERED_VERSIONS.index(self.metadata[ORIGINAL_CWLVERSION]) >= ORDERED_VERSIONS.index("v1.3.0-dev1"):to only change behavior for CWL v1.3.0+ - add tests here for the previous behavior using
cwlVersion: v1.0,cwlVersion: v1.1, andcwlVersion: v1.2
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
|
@mr-c as I wrote in the CWL v1.3 spec, I assumed undefined behavior for previous CWL versions, meaning that any implementation is free to do whatever it wants. Therefore, I am completely against putting conformance test for an undefined behavior just because |
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
508a0fe to
18da237
Compare
|
@GlassOfWhiskey I agree, I was asking for tests in cwltool, not new conformance tests. That way we don't break anything for cwltool users running a |
a2bd421 to
35f1147
Compare
35f1147 to
8d0236e
Compare
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
78c9daa to
13f8437
Compare
f8ba35d to
dbfbfab
Compare
This commit discards all fields that are present in a
cwl.output.jsonfile but have not been declared in theoutputssection of the relatedCommandLineTool, implementing common-workflow-language/cwl-v1.3#80.Conformance tests for this update have been implemented in common-workflow-language/cwl-v1.3#81.