-
Notifications
You must be signed in to change notification settings - Fork 377
develop2 branch already exists, impossible to create #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop2
Are you sure you want to change the base?
Conversation
|
Unfortunately, I don't have right to see the failing reason: failing checks: |
With `git checkout -b develop2 origin/develop2` we will see an error: fatal: a branch named 'develop2' already exists
installation.rst
Outdated
| $ git fetch --all | ||
| $ git checkout -b develop2 origin/develop2 | ||
| $ git checkout develop2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ git fetch --all | |
| $ git checkout -b develop2 origin/develop2 | |
| $ git checkout develop2 | |
| # Make sure you are in the 'develop2' branch |
The develop2 is already the default branch, should be the one checked-out after git clone, this is not really necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the same code that exists on line 143
Should we drop that line as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that line can be removed too, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm start thinking that mentioning the exact branch develop2 may be not needed at all. I mean that if the user just want to build from source, default branch should be OK for them. It will be even OK when, for instance, default branch will be changed to develop3 etc :)
In case he is interesting in some other branch, it's very likely to expect that he knows how to change the branch to desired one.
Hence, can we drop even your suggested comment?
# Make sure you are in the 'develop2' branch
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, sounds good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit added
With
git checkout -b develop2 origin/develop2we will see an error: