Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of minor fixes to cimpl. Probably nothing that will impact real-life use-cases, since these are all buried inside
_AdminClientImpl, but they were bothering me."topic_names"and"future"inkwsarray inAdmin_describe_topics()If a user tried to pass
topic_namesorfutureinto_AdminClientImpl.describe_topics()as keyword arguments, they would end up swapped, which would lead to confusing errors.TypeErrorinAdmin_list_consumer_group_offset()ifrequestis not a listTypeErrorinAdmin_alter_consumer_group_offsets()ifrequestis not a listIn both of these cases, the library would raise
ValueErrorifrequestwas a list with anything other than 1 item... but ifrequestwasn't a list, it would result in an internal error when it tried to access its first item.plistinpy_to_c_parts()to be instances of a subtype ofTopicPartitionIf a user passed a list of instances of a subtype of
TopicPartition, the library would raise aTypeError, even if the instances were otherwise valid.