Skip to content

Slirp: Remove for Podman6 #27338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: main
Choose a base branch
from
Draft

Slirp: Remove for Podman6 #27338

wants to merge 53 commits into from
+15,334 −2,467

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 21, 2025

Does this PR introduce a user-facing change?

Slirp support has been removed.

@lsm5 lsm5 added the 6.0 Breaking changes for Podman 6.0 label Oct 21, 2025
@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Oct 21, 2025
@lsm5 lsm5 added No New Tests Allow PR to proceed without adding regression tests and removed kind/api-change Change to remote API; merits scrutiny labels Oct 21, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
lsm5 added 21 commits November 10, 2025 13:20
@lsm5
cmd/podman.persistentRunE(): Fatal linux check if no Cgroups v2
de26530 
Will log and proceed on non-linux env.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
cmd/podman/containers/unpause: Remove cgroupv1 check
8846d1e 
This didn't error check for mounted cgroups, only errored for rootless
cgroupsv1 containers. Safe to remove.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_internal*.go: Remove Cgroups v1
49943da 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/info_linux.go: Remove Cgroups v1
5d39107 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime_linux.go: Remove Cgroups v1
2ba50f4 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime_pod_linux.go: Remove Cgroups v1
a1b2b86 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/domain/infra/runtime_libpod.go: Remove Cgroups v1
afcac3b 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/generate/validate_linux.go: Remove Cgroups v1
30c6df7 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime_ctr.go: Remove Cgroups v1
b6d2edb 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/runtime.go: Remove Cgroups v1
81c3064 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/util_linux.go: Remove Cgroups v1
3a04ccc 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/pod_api.go: Remove Cgroups v1
70dc291 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/namespaces.go: Remove Cgroups v1
c6ecc1b 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/domain/infra/abi/pods_stats.go: Remove Cgroups v1
ecf7f7f 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/domain/infra/abi/containers.go: Remove Cgroups v1
4984ec0 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/api/handlers/libpod/containers_stats.go: Remove Cgroups v1
103dafc 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
cmd/podman/system/service_abi_linux.go: Remove Cgroups v1
8adc31c 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/api/handlers/compat/containers_create.go: Remove Cgroups v1
c10f35c 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/e2e: delete CgV1 skips, delete tests skipped on Cgv2
471feaf 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/system: delete CgV1 skips and skipped CgV2 tests
c09e4bf 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
docs: Remove Cgroups v1
51e47cf 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5 added 3 commits November 10, 2025 14:55
@lsm5
libpod/container_api.go: Remove slirp
4f70731 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_internal_common.go: Remove slirp
2fb7394 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_internal_freebsd.go: Remove slirp
b0ebc03 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025
@github-actions github-actions bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Change to remote API; merits scrutiny labels Nov 10, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 10, 2025

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

1 similar comment
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 10, 2025

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

lsm5 added 12 commits November 10, 2025 16:03
@lsm5
libpod/container_internal_linux.go: Remove slirp
6f883c4 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/define/info.go: Remove slirp
6bd9946 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/info_linux.go: Remove slirp
75cd973 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_common.go: Remove slirp
8e39f4b 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/oci_conmon_common.go: Remove slirp
2c58d81 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/e2e: Remove slirp
b6bcd3f 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/system: Remove slirp
7910f3e 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
TMT: remove slirp4netns dependency
2c0e36d 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
RPM: remove slirp4netns
d651703 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_linux.go: Remove slirp
c5f8c12 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_slirp4netns.go: Remove Slirp4netns
42835ad 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/namespaces/namespaces.go: Remove slirp
fc66fc1 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5 added 3 commits November 10, 2025 16:20
@lsm5
libpod: Remove network-cmd-path
25b0513 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Cirrus: Remove slirp4netns from logcollector script
c2c490c 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_freebsd.go: Remove getSlirp4netnsIP()
d7744ec 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 10, 2025

tmt tests failed for commit d7744ec. @lsm5, @psss, @thrix please check.

@psss
Copy link

psss commented Nov 11, 2025

Yeah, that sounds like a genuine problem on the podman side:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x55dadaac0a55]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.0 Breaking changes for Podman 6.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Change to remote API; merits scrutiny No New Tests Allow PR to proceed without adding regression tests release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsm5 @psss @openshift-merge-robot