-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(kube play): flag to specify resources (pods, secrets, volumes) labels #26450 #27481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated comment formatting for consistency across multiple files in the `inf`, `tomb`, and `yaml` packages. - Removed unnecessary blank lines and adjusted indentation for better readability. - Ensured that comments are aligned and properly formatted to enhance clarity. - Made minor adjustments to the structure of comments to follow a uniform style.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Retr0-XD The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your contribution.
Please review this checklist and our guidelines for more information.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
- Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
commits. (git commit -s). (If needed, usegit commit -s --amend). The author email must match
the sign-off email address. See CONTRIBUTING.md
for more information. - Referenced issues using
Fixes: #00000in commit message (if applicable) - Tests have been added/updated (or no tests are needed)
- Documentation has been updated (or no documentation changes are needed)
- All commits pass
make validatepr(format/lint checks) - Release note entered in the section below (or
Noneif no user-facing changes)
And also, don't forget to add a release note in the PR description.
```release-note
<ReleaseNoteText>
```
Contributing guidelines:
https://github.com/containers/podman/blob/main/CONTRIBUTING.md#submitting-pull-requests
I did a quick review of the changes and noticed there are a lot of updates in the vendor directory.
Could you please either rebase on the main branch or move these vendoring changes into a separate commit? (I haven't reviewed the changes in the vendor directory, but I see in the description you did some formatting. Please avoid doing that here. Also, this should be in a separate commit.)
|
Direct changes to the vendor directory (including the test/vendor directory) are not acceptable; these are external libraries we build against. Either revert these changes or make them upstream, in the relevant libraries, and update to versions of those libraries with the fixes. Given these are almost all not relevant to this PR I strongly suggest dropping them and submitting a patch with only your |
inf,tomb, andyamlpackages.for feat(kube play): flag to specify resources (pods, secrets, volumes) labels #26450