Skip to content

Update UsersController.cs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update UsersController.cs #1

wants to merge 1 commit into from

Conversation

@stevel0pez
Copy link

@stevel0pez stevel0pez commented Oct 16, 2019

We should check the requester's rights before making the trip to the db.

Update UsersController.cs
5b122d9 
check rights before going to database
Berkmann18
Berkmann18 reviewed Jun 24, 2020
View reviewed changes
Copy link

@Berkmann18 Berkmann18 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think that would make the code less efficient?

@AcidRaZor
Copy link

AcidRaZor commented Aug 18, 2020

Don't you think that would make the code less efficient?

@Berkmann18
Why would checking if you're an admin first and then make a call to the database to retrieve the user, be less efficient? Currently you call the database first (overhead), and THEN check if the user requesting the information is an admin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Berkmann18 Berkmann18 Berkmann18 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevel0pez @AcidRaZor @Berkmann18