[DOC-13594] Fix Latin Abbreviation Flags #42
Conversation
…Couchbase Version). Add style guide page to explain. Remove Latin abbreviation flagging from Terminology.yml to replace with Latin.yml.
ValeStyles/Couchbase/Latin.yml
Outdated
| action: | ||
| name: replace | ||
| swap: | ||
| '(?i)\b(?:e\s*\.?\s*g\s*\.?)': for example |
There was a problem hiding this comment.
will that also catch e.g. "egg" (because there's no \b after the 'g'?
There was a problem hiding this comment.
these regexes are quite hard to read.
Could we perhaps:
- skip the
\s*before the dots, they're not really correct anyway - skip the non-capturing
?: - make the options explicit
- don't need to worry about the final ., as that'll trigger
\banyway - consider more explicit alternatives, like
\b(eg|e[.] ?g)\bwhere you at least seeegtogether at one point
There was a problem hiding this comment.
I was being a little lazy and just used Mr. Gippity for this. Try the cleaned up versions - "egg" will no longer be flagged.
ValeStyles/Couchbase/Latin.yml
Outdated
| swap: | ||
| '(?i)\be*\.?g\.?\b': for example | ||
| '(?i)\bi\.?e\.?\b': specifically | ||
| '(?i)\betc\.?|etc\.?|e\.t\.c\b': and so on |
There was a problem hiding this comment.
I think if you have alternatives | then you'll need to group them in parens, otherwise you'll get the \b only associated with the first and last alternative
ValeStyles/Couchbase/Latin.yml
Outdated
| action: | ||
| name: replace | ||
| swap: | ||
| '(?i)\be*\.?g\.?\b': for example |
There was a problem hiding this comment.
e* isn't what we want, it will match the empty string '' and 'eeee' etc.
I think this is correct now 😓 * parens needed to group alternatives * `scope: raw` needed to process "i. e" (otherwise dot-space combo starts a new sentence scope) * if we didn't care about the dot-space usage, we might be able to simplify by removing `nonword: true`? * I didn't bother checking for multiple spaces, because the kind of person who writes "i. e ." isn't going to be controlled by mere Vale rules. This is the kind of nitty gritty stuff that the test cases would be useful to debug! I'll get my PR updated and merged in after you merge this one 👍
osfameron
left a comment
osfameron
left a comment
There was a problem hiding this comment.
Looks good!
Don't worry about the failing test - that's because I had to add the workflow to main in order to test it in branch.
Once you're merged in, I'll update my PR to fix all tests, and merge it finally.
Remove Latin.yml (Google Version).
Create new Latin.yml (Couchbase Version).
Add style guide page to explain.
Remove Latin abbreviation flagging from Terminology.yml to replace with Latin.yml.