Skip to content

Conversation

@JeffGarland
Copy link
Member

@JeffGarland JeffGarland commented Oct 19, 2025

Also fixes US 113-173 (C++26 CD)

Fixes cplusplus/nbballot#991

@jensmaurer
Copy link
Member

Please read https://github.com/cplusplus/draft/wiki/Commit-message-format in its entirety, adjust the commit message, and force-push.

@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. ballot-comment Response to an NB or ISO comment on a ballot labels Oct 19, 2025
@JeffGarland JeffGarland changed the title cd26-178 resolve US-113 meta.reflection.extract [meta.reflection.extract] rm second constexpr if Oct 19, 2025
@jensmaurer
Copy link
Member

jensmaurer commented Oct 20, 2025

The commit message is still missing "Fixes US 113-173 (C++26 CD)."

Having this in the pull request is good, but not enough. And we don't want "also fixes", because this is a genuine editorial issue, not an application of a paper or LWG/CWG issue resolution (as approved by plenary).

And while we're at it, "rm" is not an English word.

@JeffGarland
Copy link
Member Author

sorry @jensmaurer, still learning the rules. Hopefully it's right now.

@eisenwave
Copy link
Member

@JeffGarland it's easiest if you look at the other PRs labeled ballot-comment for guidance. There should be a single commit with title/first line:

[meta.reflection.extract] Remove second "constexpr" in if statement

The second line of the commit message should be:

Fixes NB US 113-173 (C++26 CD).

Fixes NB US 113-173 (C++26 CD).
@JeffGarland
Copy link
Member Author

Thx @eisenwave - done.

@jensmaurer
Copy link
Member

@JeffGarland , thanks for the updates.

Could you now please squash the two commits and force-push, making sure the merged commit message is correct? "git log" helps to find existing, similar commit messages. As a bonus, please also adjust the title of this pull request to match the first line of the commit message.

Thank you.

@JeffGarland JeffGarland changed the title [meta.reflection.extract] rm second constexpr if [meta.reflection.extract] remove second constexpr if Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ballot-comment Response to an NB or ISO comment on a ballot changes requested Changes to the wording or approach have been requested and not yet applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants