-
Couldn't load subscription status.
- Fork 797
[meta.reflection.extract] remove second constexpr if #8349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Please read https://github.com/cplusplus/draft/wiki/Commit-message-format in its entirety, adjust the commit message, and force-push. |
|
The commit message is still missing "Fixes US 113-173 (C++26 CD)." Having this in the pull request is good, but not enough. And we don't want "also fixes", because this is a genuine editorial issue, not an application of a paper or LWG/CWG issue resolution (as approved by plenary). And while we're at it, "rm" is not an English word. |
|
sorry @jensmaurer, still learning the rules. Hopefully it's right now. |
|
@JeffGarland it's easiest if you look at the other PRs labeled The second line of the commit message should be: |
Fixes NB US 113-173 (C++26 CD).
|
Thx @eisenwave - done. |
|
@JeffGarland , thanks for the updates. Could you now please squash the two commits and force-push, making sure the merged commit message is correct? "git log" helps to find existing, similar commit messages. As a bonus, please also adjust the title of this pull request to match the first line of the commit message. Thank you. |
Also fixes US 113-173 (C++26 CD)
Fixes cplusplus/nbballot#991