fix: pin Python to 3.12 #362

2bndy5 · 2025-10-27T21:49:14Z

As of Ubuntu 24.04 LTS, the default version of Python is 3.12. Whereas, Ubuntu 22.04 LTS used Python 3.10, which is reaching End-of-Life next week.

Apparently, I already had created a .python-version file locally, but it was gitignored without my knowledge.

This should helps us control upgrades to Python version while some dependencies, namely pygit2, need extra time to add support for the new Python versions.

It also helps avoid disruption for users that are not aware of our use of a Python venv.

Summary by CodeRabbit

Chores
- Project now explicitly specifies Python 3.12 as the required runtime, ensuring consistent environments.
- Python runtime specifier is now tracked in version control (no longer ignored).
- CI triggers updated to respond to changes in the tracked Python version and the project's lockfile instead of the previous requirements file.
- CI setup updated to use a newer UV tool version for dependency/setup steps.

As of Ubuntu 24.04 LTS, the default version of Python is 3.12. Whereas, Ubuntu 22.04 LTS used Python 3.10, which is reaching End-of-Life next week. Apparently, I already had created a .python-version file locally, but it was gitignored without my knowledge. This should helps us control upgrades to Python version while some dependencies, namely `pygit2`, need extra time to add support for the new Python versions. It also helps avoid disruption for users that are not aware of our use of a Python venv.

coderabbitai · 2025-10-27T21:50:36Z

Warning

Rate limit exceeded

@2bndy5 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0a2e5 and c811413.

📒 Files selected for processing (1)

.github/workflows/self-test.yml (1 hunks)

Walkthrough

Removed the pyenv ignore block from .gitignore, added a .python-version file specifying Python 3.12, updated the CI workflow triggers to watch .python-version and uv.lock instead of requirements.txt, and bumped UV_VERSION in action.yml from 0.8.11 to 0.9.5.

Changes

Cohort / File(s)	Change Summary
Python version config `\.gitignore`, `\.python-version`	Deleted the "# pyenv" block and `.python-version` entry from `.gitignore` so `.python-version` is tracked; added `.python-version` with content `3.12`.
CI workflow triggers `.github/workflows/self-test.yml`	Replaced `requirements.txt` path filters in `push`, `pull_request`, and `pull_request_target` triggers with `\.python-version` and `uv.lock`. No other workflow logic changed.
Action setup `action.yml`	Updated `UV_VERSION` used during setup from `0.8.11` to `0.9.5`. No other action inputs or steps changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pay attention to action.yml UV_VERSION change for compatibility with existing tooling.
Confirm uv.lock is the intended lockfile and that triggering on .python-version is desired.
Verify adding .python-version to VCS aligns with project policy.

Possibly related PRs

fix: venv usage #314 — modifies action.yml related to uv setup and workflow inputs (overlaps with UV_VERSION change).
feat: migrate to uv and use nu shell #306 — action/workflow changes to migrate to uv and its lock file (overlaps on CI behavior and config).

Suggested labels

python

Suggested reviewers

shenxianpeng

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "fix: pin Python to 3.12" is clear, specific, and directly aligned with the main objective of the changeset. The title concisely captures the primary action being taken—pinning the repository's Python version to 3.12—which is the core purpose driving all the changes in this PR. All major modifications (removing .python-version from .gitignore, adding the .python-version file, and updating workflow triggers) directly support this objective. The title uses conventional commit formatting with a "fix:" prefix, is concise, and provides meaningful information about the changeset without attempting to cover secondary updates like the UV_VERSION bump, which is acceptable per the evaluation criteria.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-10-27T21:53:19Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted

docs/examples/demo/demo.hpp
docs/examples/demo/demo.cpp

clang-tidy (v16.0.6) reports: 7 concern(s)

docs/examples/demo/demo.hpp:6:11: warning: [modernize-use-default-member-init]

use default member initializer for 'useless'
```
    char* useless;
          ^
                 {"\0"}
```
docs/examples/demo/demo.hpp:7:9: warning: [modernize-use-default-member-init]

use default member initializer for 'numb'
```
    int numb;
        ^
            {0}
```

docs/examples/demo/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

    void *not_useful(char *str){useless = str;}
    ~~~~~~^
    auto                        -> void *

docs/examples/demo/demo.cpp:3:10: warning: [modernize-deprecated-headers]

inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead
```
#include <stdio.h>
         ^~~~~~~~~
         <cstdio>
```
docs/examples/demo/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
int main(){
~~~ ^
auto       -> int
```
docs/examples/demo/demo.cpp:10:13: warning: [readability-braces-around-statements]

statement should be inside braces
```
    for (;;) break;
            ^
             {
```
docs/examples/demo/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions
```
    printf("Hello world!\n");
    ^
```

Have any feedback or feature suggestions? Share it here.

2bndy5 · 2025-10-27T22:04:35Z

No Python version file found in workspace: /home/runner/work/cpp-linter-action/cpp-linter-action

It looks like this .python-version file is either not present or not getting noticed by uv.

2bndy5 · 2025-10-27T22:10:53Z

No Python version file found in workspace: /home/runner/work/cpp-linter-action/cpp-linter-action

It looks like this .python-version file is either not present or not getting noticed by uv.

Oh that error was from self-test using main branch (pull_request_target event). The .python-version file is indeed being used in self-test on this branch:

Reading Python requests from version file at /Users/runner/work/cpp-linter-action/cpp-linter-action/.python-version

2bndy5 · 2025-10-27T22:20:51Z

.github/workflows/self-test.yml

+  # pull_request_target:
+  #   branches: [main]
+  #   paths:
+  #     - 'action.yml'
+  #     - '.python-version'
+  #     - 'uv.lock'
+  #     - 'docs/examples/demo/**'
+  #     - '.github/workflows/self-test.yml'


This change will not take effect until merged to main.

FYI, it doesn't make sense to use thread-comments and pull_request_target together. Also pull_request and pull_request_target produce duplicate runs, but pull_request_target doesn't run against the proposed changes.

2bndy5 requested a review from a team as a code owner October 27, 2025 21:49

2bndy5 requested review from shenxianpeng and removed request for a team October 27, 2025 21:49

2bndy5 added the bug Something isn't working label Oct 27, 2025

update paths that trigger self-test CI

e2dddd1

bump uv version

7a0a2e5

2bndy5 force-pushed the pin-python branch from 79810f5 to e45c0b7 Compare October 27, 2025 22:13

remove duplicate/faulty CI trigger

c811413

2bndy5 force-pushed the pin-python branch from e45c0b7 to c811413 Compare October 27, 2025 22:17

2bndy5 commented Oct 27, 2025

View reviewed changes

2bndy5 mentioned this pull request Oct 27, 2025

chore(deps): bump hustcer/setup-nu from 3.20 to 3.21 in the actions group #361

Merged

shenxianpeng approved these changes Oct 28, 2025

View reviewed changes

2bndy5 merged commit d01bd3e into main Oct 28, 2025
73 of 86 checks passed

2bndy5 deleted the pin-python branch October 28, 2025 03:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: pin Python to 3.12 #362

fix: pin Python to 3.12 #362

2bndy5 commented Oct 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 27, 2025 •

edited

Loading

Rate limit exceeded

Uh oh!

github-actions bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

2bndy5 commented Oct 27, 2025

Uh oh!

2bndy5 commented Oct 27, 2025

Uh oh!

2bndy5 Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: pin Python to 3.12 #362

fix: pin Python to 3.12 #362

Conversation

2bndy5 commented Oct 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

2bndy5 commented Oct 27, 2025

Uh oh!

2bndy5 commented Oct 27, 2025

Uh oh!

2bndy5 Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

2bndy5 commented Oct 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 27, 2025 •

edited

Loading

github-actions bot commented Oct 27, 2025 •

edited

Loading