Fix webpack export #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't update to 12 yet because gulp v3 doesn't support it.
Found out that the default webpack works just fine for us, and specify and entry point actually creates an error. This is the advised usage on https://github.com/webpack-contrib/karma-webpack
Jasmine 3.x introduces randomised order in tests, which we can't support for the webpack tests, so we disabled it. Otherwise everything works fine (tested by commenting out some tests).
saveman71
force-pushed
the
fix-webpack-export
branch
from
c7b2d31 to
e80e08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes the exported value of the module.
It also upgrades several dev dependencies: no code change except to the change of exported module.
What is the current behavior? (You can also link to an open issue here)
#28
Does this PR introduce a breaking change?
Maybe? Depending on how people were using the exported value before. I'd say stay on the safe side and just bump to v2.
Please check if the PR fulfills these requirements
Other information:
Feel free to use part or all commits :)