#3330. Add static extensions tests. Part 2. #3382
Conversation
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good, couple of comments!
| } | ||
|
|
||
| extension ExtE on E { | ||
| static int get foo => 42; |
There was a problem hiding this comment.
And ExtE2/3 that has a method or variable foo?
There was a problem hiding this comment.
Please clarify. In this test we have variable/getter/method declared in class/mixin/extension type and a setter dectared in an extension. The test checks that it is an error to call the setter. But for the enum we have a setter declared in the enum and a getter declared in the extension. Then we check that it is an error to call the getter. Why do we need additional extentions for the enum?
There was a problem hiding this comment.
We're checking the situation where the on declaration has a variable, a method, and a getter, and an extension has a setter.
So I thought we could have a corresponding set of tests where the on declaration has a setter, and an extension has a variable; the on declaration has a setter and an extension has a method; and the on declaration has a setter and an extension has a getter.
It might not be important or useful, but couldn't those scenarios cover different parts of the implementation of the tools?
There was a problem hiding this comment.
Got it now. Makes sense. Added static_member_A04_t02.dart. PTAL.
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Updated. Typos are fixed. One question about additional extentions. PTAL.
| } | ||
|
|
||
| extension ExtE on E { | ||
| static int get foo => 42; |
There was a problem hiding this comment.
Please clarify. In this test we have variable/getter/method declared in class/mixin/extension type and a setter dectared in an extension. The test checks that it is an error to call the setter. But for the enum we have a setter declared in the enum and a getter declared in the extension. Then we check that it is an error to call the getter. Why do we need additional extentions for the enum?
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Just one comment thread still being resolved.
| } | ||
|
|
||
| extension ExtE on E { | ||
| static int get foo => 42; |
There was a problem hiding this comment.
We're checking the situation where the on declaration has a variable, a method, and a getter, and an extension has a setter.
So I thought we could have a corresponding set of tests where the on declaration has a setter, and an extension has a variable; the on declaration has a setter and an extension has a method; and the on declaration has a setter and an extension has a getter.
It might not be important or useful, but couldn't those scenarios cover different parts of the implementation of the tools?
2 participants
No description provided.